feat(mobile): bring GitLab and Bitbucket code review up to the GitHub workflow (part 2/2) - #6021
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of the two files changed since Files Reviewed (2 files)
Previous Review Summaries (5 snapshots, latest commit ddc9e51)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit ddc9e51)Status: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of the files changed since Files Reviewed (4 files)
Previous review (commit 1ae8ec2)Status: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of the 8 files changed since Files Reviewed (8 files)
Previous review (commit e714694)Status: 2 Issues Found | Recommendation: Address before merge Executive SummaryTwo provider-parity regressions remain on the current head: the shared overview still renders GitHub-only reconnect copy (with the recovery CTA removed) for GitLab/Bitbucket, and the new-session branch scope is published in a passive effect that is never reset, so a remount can query Overview
Issue Details (click to expand)WARNING
Files Reviewed (152 files: 91 source + 61 test; 87 generated i18n catalogs and the lockfile excluded)
Fix these issues in Kilo Cloud Previous review (commit 2c804a5)Status: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
WARNING
SUGGESTION
Files Reviewed (4 files)
Fix these issues in Kilo Cloud Previous review (commit 35421e1)Status: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
35421e1 to
fc000dc
Compare
8d3940d to
2c804a5
Compare
2c804a5 to
7bc2d61
Compare
7bc2d61 to
cd7d47c
Compare
cd7d47c to
e714694
Compare
e714694 to
54e2e17
Compare
54e2e17 to
1ae8ec2
Compare
1ae8ec2 to
ddc9e51
Compare
…yer for mobile (part 1/2) #6006
… workflow (part 2/2) #6021
ddc9e51 to
62c2de2
Compare
Changelog for users
Changelog for maintainers
apps/mobile/src/app/(app)/pr-review/[platform]/[...identity]/_layout.tsx:116— accepted:indexis registered ahead of the sheets, so the overview is the initial provider-review screen; a test runs the router's sorter to lock the order.patches/expo-router@57.0.15.patch:1— accepted: the patch again keepsExpoRouterModule.kt; it now carries only the two JavaScript linking fixes, and the lockfile hash is updated.apps/mobile/src/lib/pr-review/use-provider-inbox.ts:241— accepted: GitHub reads now require the user's authorization; revoked access surfaces a reconnect action, and retries re-run the authorization check.apps/mobile/src/app/(app)/agent-chat/repo-picker.tsx:201— accepted: the Bitbucket organization-only note keys on personal context, not on a missing section, so an organization with no Bitbucket rows sees no note.apps/mobile/src/components/pr-review/pr-review-overview.tsx:163— accepted: non-GitHub reconnect states render the shared provider reconnect notice with the provider's own title/message and a working "Check connection" CTA; GitHub keeps its centered empty state with an unconditional CTA, and a mounted test asserts the GitLab notice and CTA.apps/mobile/src/lib/use-new-session-repos.ts:61— accepted: the scope effect clears the published organization on unmount, so a remount issues no branch query until the next screen publishes its scope;resetNewSessionBranchScopereturns the branch store to "not ready" and no-ops when already un-scoped, with store and hook tests.pb-8for a safe-area spacer fromuseDetailScreenBottomPadding, and the test pins the 60px clearance for the 44px mocked inset.E2E proof
Proof is stack-wide on the current build. The new provider-reconnect and branch-scope runs are the current proof; they replace the superseded checks-loading frames, which are removed. The retained provider captures for the inline comment thread, the branch row, and the Bitbucket personal state stay valid. The recording has waits trimmed, and the change forks on no platform, so one device covers both.
scripted-shard1.mp4.trim.mp4
e1-gitlab-handoff.mp4.trim.mp4
Owner request for the stack